Repository navigation
Add LiveResponseMustBeReturnedByLiveActionRule - #27
Merged
Merged
Conversation
Kocal
force-pushed
the
feature/live-response-rule
branch
2 times, most recently
from
November 8, 2026 06:42
6c0e1ab to
47a849f
Compare
Returning a `LiveResponse` (added in `symfony/ux-live-component` 3.5) from the default action (`__invoke()` or the `defaultAction` of `#[AsLiveComponent]`) makes Symfony UX throw a `LogicException` at runtime. The rule reports it, and also reports a public method returning a `LiveResponse` without `#[LiveAction]` or `#[LiveListener]`, since the browser cannot call it. The tests use a `LiveResponse` stub because 3.5 requires PHP 8.4 while the CI runs PHP 8.2.
Kocal
force-pushed
the
feature/live-response-rule
branch
from
November 8, 2026 07:01
47a849f to
095475c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Returning a
LiveResponse(added insymfony/ux-live-component3.5) from the default action (__invoke()or thedefaultActionof#[AsLiveComponent]) makes Symfony UX throw aLogicExceptionat runtime. The rule reports it, and also reports a public method returning aLiveResponsewithout#[LiveAction]or#[LiveListener], since the browser cannot call it.The tests use a
LiveResponsestub because 3.5 requires PHP 8.4 while the CI runs PHP 8.2.